Web lists-archives.com

Re: [PATCH] Implement changing resolution on the fly for zr364xx driver




Hi,

This patch implements changing resolution in zr364xx_vidioc_s_fmt_vid_cap for zr364xx driver. This version is synced with v4l-dvb as of 20/Jul/2009. Tested with Creative PC-CAM 880.

Nice, I successfully tested your patch with 2 compatible webcams.
From the users feedbacks I had before, it seems that some devices do not support the 640x480 resolution, but I was not able to verify this myself. This is the only concern I have, since some users may think the driver is not working if the application automatically switches to the maximum resolution with an incompatible device.

OBS: I had to increase MAX_FRAME_SIZE to prevent a hard crash in my notebook (caps lock blinking) when testing with mplayer, which automatically sets resolution to the maximum (640x480). Maybe we should add code to auto-detect frame size to prevent this kind of crash in the future.

Yes, I also had this issue before. I don't know what is the good approach to determine the best size with JPEG compression.

I will push your changes to my tree and send a pull request to Mauro later.

Regards,

Antoine

--
Antoine "Royale" Jacquet
http://royale.zerezo.com

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list