Web lists-archives.com

Re: saa7134/2.6.26 regression, noisy output




An update:

>hermann-pitton@xxxxxxxx said:
>> hmm, the idea eventually was, to download these two snapshots, or make the
>> last few changes manually on the first and try on 2.6.25.
>>
>> Then we might know, if the problem is already visible within Hartmut's latest
>> fix attempts or even more and other stuff is involved. 

I wrote:
>I see. I'll dig myself into hand applying those patches. It seems quite some 
>stuff changed between 2.6.25 and what those patches assumes. Let's see what I
>dig up.


Dragging the following patch along,
diff --git a/drivers/media/video/saa7134/saa7134-cards.c b/drivers/media/video/saa7134/saa7134-cards.c
index 6fde042..938bdf5 100644
--- a/drivers/media/video/saa7134/saa7134-cards.c
+++ b/drivers/media/video/saa7134/saa7134-cards.c
@@ -5249,7 +5249,7 @@ static int saa7134_tda8290_callback(struct saa7134_dev *dev,
 int saa7134_tuner_callback(void *priv, int command, int arg)
 {
        struct i2c_algo_bit_data *i2c_algo = priv;
-       struct saa7134_dev *dev = i2c_algo->data;
+       struct saa7134_dev *dev = priv;
 
        switch (dev->tuner_type) {
        case TUNER_PHILIPS_TDA8290:

.. I could actually bisect my way to the offending commit. And of course, it's 
the one you suspected: git 7bff4b4d3ad2b9ff42b4087f409076035af1d165.


I'm right now applying that commit piece by piece, to isolate the offending
change (Some changes are just rearrangements, others may change the way hw is
touched). I'll keep you posted.

-Anders




--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list