Web lists-archives.com

Re: [Spca50x-devs] PATCH: gspca-mercurial OV7630 light frequency filter




Hans,

I have some good news for you,
 
1) Make sure my cleanup didn't break anything

The cleanup works fine, the webcam still works fine.

2) Maybe 160x120 will work now, I would like to get
   rid of the (product == 0x60b0) special case
   in the setting up of cam_modes

I've tested this and now the webcam works fine in 160x120!

3) I think that the special probe sequence send at the
   end of sd_config for your cam is not really necessary,
   can you comment it and see if things still work?
 
We don't need it! I've removed it and still works fine. I don't know why Windows driver sent this at probe time.

   (The led might be left on after plugging in the cam,
    until you've started a v4l app atleast once. I have that issues with one my
    cams too, and I'm planning on writing a generic fix for this).

About the led being on after plugging the cam, never happened to me with gspca. It happens with sn9c102 kernel driver. It's still not happening with the last patches.

I attach the patch that applies the modifications I've tested.

Thanks for your time,

Regards,

Andoni

diff -r 80f6ae943cdf linux/drivers/media/video/gspca/sonixb.c
--- a/linux/drivers/media/video/gspca/sonixb.c	Tue Jul 22 12:13:21 2008 +0200
+++ b/linux/drivers/media/video/gspca/sonixb.c	Tue Jul 22 08:17:19 2008 -0300
@@ -197,8 +197,6 @@
 		.colorspace = V4L2_COLORSPACE_SRGB,
 		.priv = 0},
 };
-
-static const __u8 probe_ov7630[] = {0x08, 0x44};
 
 static const __u8 initHv7131[] = {
 	0x46, 0x77, 0x00, 0x04, 0x00, 0x00, 0x00, 0x80, 0x11, 0x00, 0x00, 0x00,
@@ -861,11 +859,6 @@
 	if (!sif) {
 		cam->cam_mode = vga_mode;
 		cam->nmodes = ARRAY_SIZE(vga_mode);
-		if (product == 0x60b0) { /* SN9C103 with OV7630 */
-			/* We only have 320x240 & 640x480 */
-			cam->cam_mode++;
-			cam->nmodes--;
-		}
 	} else {
 		cam->cam_mode = sif_mode;
 		cam->nmodes = ARRAY_SIZE(sif_mode);
@@ -875,9 +868,6 @@
 	sd->exposure = EXPOSURE_DEF;
 	sd->autogain = AUTOGAIN_DEF;
 	sd->freq = FREQ_DEF;
-
-	if (product == 0x60b0) /* SN9C103 with OV7630 */
-		reg_w(gspca_dev, 0x01, probe_ov7630, sizeof probe_ov7630);
 
 	return 0;
 }
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Spca50x-devs mailing list
Spca50x-devs@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/spca50x-devs