Web lists-archives.com

Re: [Samba] selftest

On 4/1/2019 8:03 PM, Andrew Bartlett wrote:
This looks likehttps://bugzilla.samba.org/show_bug.cgi?id=13854

This should be in a new Samba 4.10.x shortly.

I don't know why this only seems to happen on some platforms or what
exactly is going on, but yes, selftest and CI is absolutely critical to
our workflow.

Andrew Bartlett

-- Andrew Bartlett http://samba.org/~abartlet/ Authentication Developer, Samba Team http://samba.org Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba

Specifically for this issue:

is obviously wrong in having the conditional
#if defined(DEVELOPER) || defined(ENABLE_SELFTEST)
/before/ #include "includes.h"

So it looks like it should be fixed.
The question is why does it not always fail.
Maybe in some platforms ENABLE_SELFTEST is defined by adding -DENABLE_SELFTEST to the compiler cmdline instead of or in addition to "config.h"?

To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba