Web lists-archives.com

Re: [Samba] selftest




On Mon, 2019-04-01 at 17:08 +0200, Manfred via samba wrote:
> Hi all,
> 
> 
> I just downloaded a fresh samba-4.10.0 tarball to verify the result of 
> 'make test'
> What I did is:
> ./configure --enable-selftest
> make
> make test
> 
> All run as the ordinary user.
> 
> I encountered a build problem with 'make' in
> source4/lib/messaging/messaging_handlers.c
> 
> due to the following conditional being placed /before/ #include "includes.h"
> #if defined(DEVELOPER) || defined(ENABLE_SELFTEST)
> 
> I fixed this by moving the conditional after the #include, and the build 
> completed fine.
> This is the only change I made in the code.
> 
> But.
> 
> 'make test' failed miserably with tons of errors.
> 
> The presentation from Andrew Bartlett says that selftest should be 
> enforced as part of the regular release workflow, which is great, but 
> since that talk is from 2012, I wonder: what is the current status of 
> selftest ?

This looks like https://bugzilla.samba.org/show_bug.cgi?id=13854

This should be in a new Samba 4.10.x shortly.

I don't know why this only seems to happen on some platforms or what
exactly is going on, but yes, selftest and CI is absolutely critical to
our workflow.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba



-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba