Re: [MPlayer-dev-eng] [PATCH] haiku support
- Date: Fri, 8 Sep 2017 08:10:48 +0200
- From: Reimar Döffinger <Reimar.Doeffinger@xxxxxx>
- Subject: Re: [MPlayer-dev-eng] [PATCH] haiku support
On 02.09.2017, at 22:28, Compn <tempn@xxxxxxxxx> wrote:
> patch looks ok to me.
> maintained by miqlas.
> any haiku users out there? :)
Some of the files lack license headers, I don't think the ao/vo modules should be enabled unconditionally,
the libraries should be linked against depending on enabed modules, not depending on OS,
the header include guards don't have the right format (especially should not start with _),
several files miss license headers (and I don't like the MIT license one either, because then I have to check of it's compatible with GPL, plus the actual license needs to be included as well).
MPlayer-dev-eng mailing list