Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH 4/5] vo xv: Limit output formats to what the vo actually supports




Hi!

On 2017-06-27 22:13 +0200, Alexander Strasser wrote:
> On 2017-06-21 23:46 +0300, Ville Syrjälä wrote:
> > On Thu, Jun 15, 2017 at 12:50:34AM +0200, Alexander Strasser wrote:
[...]
> > > @@ -503,10 +505,25 @@ static uint32_t get_image(mp_image_t * mpi)
> > >      return VO_FALSE;
> > >  }
> > >  
> > > +static int is_supported_format(uint32_t format)
> > > +{
> > > +    switch (format) {
> > > +    case IMGFMT_YV12:
> > > +    case IMGFMT_I420:
> > > +    case IMGFMT_IYUV:
> > > +        return 1;
> > 
> > This rejects all packed formats, which is probably not what you
> > intended.
> 
> Yeah, that went too far :(
> 
> I am not yet exactly sure how I will extend this.
> 
> I was also confused because in vo xv and a (few others I guess) we
> support packed formats in draw_image but not in draw_slice.
> 
> > Apart from that the patches look good to me. And they survived
> > a quick smoke test using NV12, YV12, I420, and YUY2 (after hacking
> > it into is_supported_format()).
> 
> Thank you for testing and having a look at the patches!
> 
> I am intending to push when I have code in place to allow the packed
> formats again.

  I sent an updated patch set. It includes updated patch 5 and also
fixes this problem. Additionally I improved the cosmetics patch and
fixed a typo in one of the commit messages.

  Will give it a bit more testing and commit in a few days.


  Alexander
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng