Re: [MPlayer-dev-eng] [PATCH] Determine replay gain
- Date: Mon, 03 Apr 2017 00:49:20 +0200
- From: Ingo Brückl <ib@xxxxxxxxxxxxxxx>
- Subject: Re: [MPlayer-dev-eng] [PATCH] Determine replay gain
Reimar Döffinger wrote on Sun, 2 Apr 2017 17:41:02 +0200:
> On Fri, Mar 31, 2017 at 04:17:45AM +0200, Ingo Brückl wrote:
>> +static int r_gain;
> Shouldn't use global variables except for options (and even that
> is not a very good idea).
Yes, I know, but unfortunately mp3_vbr_frames() which determines the replay
gain doesn't have access to anything but stream_t *s. I wanted to avoid
changing its parameter list, but if it's okay to pass da_priv_t *, I'll do.
MPlayer-dev-eng mailing list