Re: [MPlayer-dev-eng] [PATCH 2/2] vo_xv: Add NV12/NV21 support
- Date: Mon, 20 Mar 2017 00:12:20 +0100
- From: Alexander Strasser <eclipse7@xxxxxxx>
- Subject: Re: [MPlayer-dev-eng] [PATCH 2/2] vo_xv: Add NV12/NV21 support
On 2017-03-07 23:46 +0200, Ville Syrjälä wrote:
> On Tue, Mar 07, 2017 at 09:48:29PM +0100, Reimar Döffinger wrote:
> > On Sun, Feb 26, 2017 at 11:57:28PM +0200, Ville Syrjälä wrote:
> > > Add support for NV12/NV21. Useful for cases when your hardware doesn't
> > > do YV12/I420.
> > It would be much easier and nicer for us to review if you could
> > simply not re-indent the code you didn't modify.
> I suppose I could have just put an early return for NV12/21 and
> leave the rest as is. But it's a fairly tiny diff so figured it's
> still legible even after diff mangles things in its usual silly way.
> But I can redo it in whatever way people prefer.
> I wonder if anyone's ever implement a diff algorithm that actually
> makes good patches? At some point I was thinking that something
> which tries to handle C blocks rather than lines might be a
> decent approach.
> > (or send a diff -uw variant or...)
I looked at the diff ignoring whitespace changes. Your patch looks
good to go.
> > Quite bit worrying that the code doesn't actually check
> > if we really support the format before it claims to support it
> > (in query_format).
> Yeah. It explodes in some interesting ways if the Xv adaptor supports
> the specified format but vo_xv doesn't. I thought about fixing it, but
> then I decided that if it's been like this all these years no one
> likely cares ;)
Kind of emberassing. I think I am going to fix it. But I can
sure apply your changes before doing that if you are in hurry.
MPlayer-dev-eng mailing list