Re: [MPlayer-dev-eng] [PATCH]can not open ISO file including multibyte file path. on Windows.
- Date: Tue, 7 Mar 2017 21:56:44 +0100
- From: Reimar Döffinger <Reimar.Doeffinger@xxxxxx>
- Subject: Re: [MPlayer-dev-eng] [PATCH]can not open ISO file including multibyte file path. on Windows.
On Mon, Mar 06, 2017 at 08:12:12AM -0500, Compn wrote:
> On Mon, 6 Mar 2017 04:56:02 +0900, Tadashi Ando <ando@xxxxxxxxxxx>
> > + HMODULE kernel32 = GetModuleHandle("Kernel32.dll");
> > + if (!kernel32) goto err_out;
> what version of windows does this work on?
We already have similar code in stream/stream_file.c,
we shouldn't duplicate it.
Also ffmpeg/libavutil/wchar_filename.h has similar code.
And lastly, considering that this code and also GUI
code just calls MultiByteToWideChar etc. directly
this whole indirection with dynamic loading is just
silly (not blaming the patch author, following existing
code style is USUALLY a good idea, but not in this case I think),
just call the functions directly.
Once that clutter is a bit reduced, it also should
be easier to review the rest of the change.
MPlayer-dev-eng mailing list