Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH] fix libass fails with -subcp enca: and external subtitles

On Tue, Feb 02, 2016 at 05:57:21PM +0300, Basin Ilya wrote:
> Hi.
> Here's a proposed patch for https://trac.mplayerhq.hu/ticket/2281

The patch seems mangled, there is an extra space in the
 +     last_sub_cp = sub_cp;
lines I think.
Also as it seems only used for ENCA, I would suggest to
name the variable enca_sub_cp, reset it to NULL and use
it like
enca_sub_cp ? enca_sub_cp : sub_cp
Well, maybe that gets a bit ugly too, but I think it should
be more obvious.
However is ENCA relevant for ASS subtitles? I thought they
have to be in UTF-8 anyway? Ok given that ass_read_stream
has a encoding argument I probably remember wrong.
MPlayer-dev-eng mailing list