Re: [MPlayer-dev-eng] [PATCH] Fix attribute parsing at SRT subtitles
- Date: Mon, 18 Jan 2016 22:43:48 +0100
- From: Roberto Togni <rxt@xxxxxxxxx>
- Subject: Re: [MPlayer-dev-eng] [PATCH] Fix attribute parsing at SRT subtitles
On Sat, 16 Jan 2016 18:20:26 +0100
Stefan Pöschel <basic.master@xxxxxx> wrote:
> I just wanted to ask if there is any further information needed
> regarding the patch.
> Am 31.12.2015 um 14:37 schrieb Stefan Pöschel:
> > Hi,
> > when SRT subtitles shall be displayed including formatting, they are
> > converted to ASS markup. The conversion therefore also processes the
> > "color" attribute of the HTML "font" tag.
> > At the moment unfortunately also affects attributes who just have
> > "color" as a prefix, e.g. the attribute "back-color" which is sometimes
> > contained in subtitles. Therefore the value of this background color
> > attribute is by mistake used to set the text color.
> > Please find attached a test SRT file (correct text color: white, not blue).
> > The attached patch fixes this parsing by also including the leading
> > space when recognizing the "color" attribute and also the other attributes.
> > Thanks and regards,
> > Stefan Pöschel
Sorry for the delay.
MPlayer-dev-eng mailing list