Re: [MPlayer-dev-eng] [MPlayer-users] Build regression on FreeBSD
- Date: Fri, 15 Jan 2016 23:52:54 +0100
- From: Roberto Togni <rxt@xxxxxxxxx>
- Subject: Re: [MPlayer-dev-eng] [MPlayer-users] Build regression on FreeBSD
On Sun, 10 Jan 2016 02:49:18 +0100
Alexander Strasser <eclipse7@xxxxxxx> wrote:
> Hi Roberto!
> On 2015-12-21 22:20 +0100, Alexander Strasser wrote:
> > On 2015-12-21 21:43 +0100, Roberto Togni wrote:
> > > > I might be missing a few things, but all in all I do not see why
> > > > we need the structure vdpau_frame_data in codec-cfg.c source. So
> > > > maybe the structure should be defined in a different header?
> > > >
> > > > All in all I see no really easy way to set HOSTCFLAGS correctly.
> > > > Additionally I am not sure if the work is justified, because if
> > > > I am not mistaken above it is not needed in codec-cfg.
> > > >
> > > Do you see the failure only in codec-cfg.c or also in the other files
> > > including vdpau.h (vd_ffmpeg and vo_vdpau)?
> > >
> > > If it's only codec-cgg.c, the easiest way is to move the structure
> > > somewhere else; I guess it was put there only because img_format.h is
> > > included both in vd_ffmpeg and vo_vdpau.
> > > The struct has always been there, but it was not using any field
> > > requiring external vdpau headers before.
> > If I am not mistaken this is the changeset from Thomas:
> > http://svnweb.freebsd.org/ports?view=revision&revision=404026
> > This is the change to the Makefile patch which extends HOSTCFLAGS only:
> > http://svnweb.freebsd.org/ports/head/multimedia/mplayer/files/patch-Makefile?r1=404026&r2=404025&pathrev=404026
> > There are more changes to configure and MPlayer's Makefile
> > in those patch files, I did not check all of them. Maybe Thomas
> > can clarify?
> > > If you can confirm that the problem is only with codec-cfg.c I'll just
> > > move the struct and the include; best candidates are vo_out.h, vd.h or a
> > > dedicated header.
> > I would favour this solutions too.
> If I didn't miss something, this was also reported by a non-BSD user on
> our bug tracker:
> Tell me if I should give it a try. I just don't want to end up doing
> duplicate work.
I haven't touched it yet, feel free to do it.
MPlayer-dev-eng mailing list