Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH]Win32: correct the encoding of filename in console message




On Sun, 9 Aug 2015 02:20:57 +0800 (CST)
朱海 <zhuhai.mail@xxxxxxx> wrote:

hello! sorry, your patch was stuck in the moderation queue.

> -    if (!mp_msg_charset ||
> -        !strcasecmp(mp_msg_charset, MSG_CHARSET) ||
> -        !strcasecmp(mp_msg_charset, "noconv"))
> +    if (!from || !to ||
> +        !strcasecmp(from, to) ||
> +        !strcasecmp(from, "noconv"))
>          return filename;
>      if (inv_msgiconv == (iconv_t)(-1)) {
> -        inv_msgiconv = iconv_open(MSG_CHARSET, mp_msg_charset);
> +        inv_msgiconv = iconv_open(to, from);


changing functions to "from" and "to" looks weird to me.



> -    HMODULE kernel32 = GetModuleHandle("Kernel32.dll");
> +    HMODULE kernel32;
> +
> +    if (!win32_use_utf8) goto fallback;
> +
> +    kernel32 = GetModuleHandle("Kernel32.dll");

why the kernel32 change?

-compn
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng