Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH] Fix spelling errors found by lintian.

On 2015-07-15 21:24 +0200, Reimar Döffinger wrote:
> On Mon, Jul 13, 2015 at 04:22:07AM -0400, Miguel A. Colón Vélez wrote:
> > The genres table seems to just translate that number into something
> > the user would understand when displayed. The typo seems to have been
> > left as is because as explained in the comment "typo taken from the
> > id3v2spec". That comment was not part of the original id3edit source
> > (from 2002) so I assumed that was the reason the typo was left
> > unchanged and that is why I mentioned it was fixed in the latest
> > id3v2spec.
> If the spec was updated, I guess it is fine to change.

  In principle I am fine with it too.

> I don't know how relevant staying in sync with upstream is,
> probably not much.
> I'd be very, very slightly in favour of changing them just to
> shut up the warnings as we'll probably never again sync
> with upstream but if others have opinions otherwise I will
> concede.

  My reasons for being unsure about it were:

  1) I was not sure if MEncoder might be affected;
     now I am rather sure it doesn't affect on MEncoder

  2) This is part of -identify output, thus it could
     cause problems for other programs parsing this output
     (e.g. using that output for grouping by genre, could
      end up with 2 instead of one groups for Psychedelic)

  I am not opposed to fixing the genre typo. In addition I
would add a sentence in Changelog that mentions it.

  FWIW to comply with what is in common range to the current
spec we would have to do these adjustments:

    25: Eurotechno -> Euro-Techno
    40: Alternative Rock -> AlternRock
    67: Psychadelic -> Psychedelic
    69: Show Tunes -> Showtunes

I do *not* think we should change the others too.

  BTW I am wondering if there is a robust way to suppress
false positives reported by lintian.


If there are no more opinions on this I will just go with
fixing the typo in genres.h .

Attachment: pgprFgjzQYvga.pgp
Description: PGP signature

MPlayer-dev-eng mailing list