Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH] Fix spelling errors found by lintian.




Hi!

On 2015-07-12 16:27 -0400, Miguel A. Colón Vélez wrote:
> Hello:
> 
> While packaging MPlayer for Debian, lintian found the following issues:

  Nice, some packaging efforts. I did some experiments for
that too last year, but did not have much time to work on it.
I will try to dig up the findings from that time.

>  I: mencoder: spelling-error-in-binary usr/bin/mencoder Psychadelic Psychedelic
>  I: mencoder: spelling-error-in-binary usr/bin/mencoder bandwith bandwidth
>  I: mplayer-gui: spelling-error-in-binary usr/bin/gmplayer Psychadelic
> Psychedelic
>  I: mplayer-gui: spelling-error-in-binary usr/bin/gmplayer bandwith bandwidth
>  I: mplayer: spelling-error-in-binary usr/bin/mplayer Psychadelic Psychedelic
>  I: mplayer: spelling-error-in-binary usr/bin/mplayer bandwith bandwidth
> 
> The following trivial patch fixes the issue and silences lintian.
> 
> Note:
>  id3v2.3.0 and earlier have the Psychadelic typo but id3v2.4.0 fixes it.
>  http://id3.org/id3v2.4.0-frames

  First of all both of the changes, are in files that were copied from
other projects.

  For the id3v2, I am not sure about the implications and if we should
really change it.

  For the "bandwith" typo in the comments/error message, I would really
rather not change it. It would make comparison to upstream harder with
not much gain.

  This is a kind of superficial response, because I do not have deep
knowledge about SDP nor about the usage of the id3v2 genre table in
MPlayer/MEncoder. I noticed that the last time the typo was changed,
it was reverted to the current state.

  Alexander


> Description: Fix spelling errors found by lintian.
>  I: mencoder: spelling-error-in-binary usr/bin/mencoder Psychadelic Psychedelic
>  I: mencoder: spelling-error-in-binary usr/bin/mencoder bandwith bandwidth
>  I: mplayer-gui: spelling-error-in-binary usr/bin/gmplayer Psychadelic Psychedelic
>  I: mplayer-gui: spelling-error-in-binary usr/bin/gmplayer bandwith bandwidth
>  I: mplayer: spelling-error-in-binary usr/bin/mplayer Psychadelic Psychedelic
>  I: mplayer: spelling-error-in-binary usr/bin/mplayer bandwith bandwidth
>  .
>  Note:
>  id3v2.3.0 and earlier have the Psychadelic typo but id3v2.4.0 fixes it.
>  http://id3.org/id3v2.4.0-frames
> Author: Miguel A. Colón Vélez <debian.micove@xxxxxxxxx>
> Forwarded: yes
> Last-Update: 2015-07-12
> 
> --- mplayer-1.1.1+svn37424.orig/libmpdemux/genres.h
> +++ mplayer-1.1.1+svn37424/libmpdemux/genres.h
> @@ -99,7 +99,7 @@ const char * const genres[] = {
>  "Native American",			/* 64 */
>  "Cabaret",					/* 65 */
>  "New Wave",					/* 66 */
> -"Psychadelic",			/* 67 */ /* typo taken from the id3v2spec*/
> +"Psychedelic",			/* 67 */
>  "Rave",						/* 68 */
>  "Show Tunes",				/* 69 */
>  "Trailer",					/* 70 */
> --- mplayer-1.1.1+svn37424.orig/stream/freesdp/common.h
> +++ mplayer-1.1.1+svn37424/stream/freesdp/common.h
> @@ -154,7 +154,7 @@ typedef enum
>  } fsdp_address_type_t;
>  
>  /**
> - * @short Type of bandwith modifiers
> + * @short Type of bandwidth modifiers
>   *
>   * Bandwidth modifiers specify the meaning of the bandwidth
>   * value. Initially "Conference Total" and "Application Specific" are
> --- mplayer-1.1.1+svn37424.orig/stream/freesdp/errorlist.c
> +++ mplayer-1.1.1+svn37424/stream/freesdp/errorlist.c
> @@ -41,7 +41,7 @@ const char *fsdp_error_t_s[] = {
>    "Syntax error in connection item", /** FSDPE_INVALID_CONNECTION **/
>    "Unrecognized address type in connection item", /** FSDPE_INVALID_CONNECTION_ADDRTYPE **/
>    "Unrecognized network type in connection item", /** FSDPE_INVALID_CONNECTION_NETTYPE **/
> -  "Parse error in bandwith item", /** FSDPE_INVALID_BANDWIDTH **/
> +  "Parse error in bandwidth item", /** FSDPE_INVALID_BANDWIDTH **/
>    "No time period for the session", /** FSDPE_MISSING_TIME **/
>    "Parse error in time item", /** FSDPE_INVALID_TIME **/
>    "Parse error in repeat time item", /** FSDPE_INVALID_REPEAT **/
> --- mplayer-1.1.1+svn37424.orig/stream/freesdp/parser.h
> +++ mplayer-1.1.1+svn37424/stream/freesdp/parser.h
> @@ -242,9 +242,9 @@ unsigned int fsdp_get_bw_modifier_count
>   * @param index number of bandwidth modifier.
>   *
>   * @return global bandwidth modifier type.
> - * @retval FSDP_BW_MOD_TYPE_UNDEFINED if no global bandwith modifier
> + * @retval FSDP_BW_MOD_TYPE_UNDEFINED if no global bandwidth modifier
>   * type is defined or invalid index.
> - * @retval FSDP_BW_MOD_TYPE_UNKNOWN if an unknown bandwith modifier is
> + * @retval FSDP_BW_MOD_TYPE_UNKNOWN if an unknown bandwidth modifier is
>   * specified or an invalid index is provided. In this case
>   * fsdp_get_bw_modifer_type_unknown() can be called to get the
>   * modifier as a character string.

Attachment: pgpE9ONbHIw5T.pgp
Description: PGP signature

_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng