Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH] vo and ao "exit" devices




On Fri, May 01, 2015 at 08:36:12PM +0200, Reimar Döffinger wrote:
> On Wed, Apr 29, 2015 at 10:22:32PM -0400, Dylan Simon wrote:
> > Someone mentioned that they wanted mplayer to exit if it failed to open their
> > audio device, rather than continuing with no audio.  These (trivial but
> > harmless) output devices allow this to happen by putting them at the end of
> > the output chain (e.g., "-ao alsa,pulse,exit").  Apparently someone else
> > suggested this approach as well, a while ago.  I will readily admit that this
> > is silly, but it works.  I have no particular attachment to name, description,
> > or approach.
> 
> It seems slightly risky to me to call exit_player for an init function.
> It tends to rely on some state that might not be set up correctly at
> that point for example.
> Also it will not exit if the AO is fine, but e.g. we cannot actually
> connect to it since it doesn't support any format we can convert to
> for example.
> It might work better adding the code to reinit_audio_chain, in the
> init_error label?
> For video, the equivalent would be reinit_video_chain, and it behaves
> quite similar.

Sorry, should have said: both these functions are in mplayer.c
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng