Re: [MPlayer-dev-eng] [PATCH 2/2] Fix compilation with recent FFmpeg on ARM
- Date: Tue, 31 Mar 2015 10:38:48 -0400
- From: Laurent <laurent.aml@xxxxxxxxx>
- Subject: Re: [MPlayer-dev-eng] [PATCH 2/2] Fix compilation with recent FFmpeg on ARM
On Sat, Mar 14, 2015 at 9:21 PM, Alexander Strasser <eclipse7@xxxxxxx> wrote:
> Hi Laurent!
> On 2015-03-13 18:18 -0400, Laurent wrote:
> > Not sure about this one: HAVE_SECTION_DATA_REL_RO.
> > It is defined for Android and Linux, see:
> > http://lists.libav.org/pipermail/libav-commits/2014-December/015860.html
> > So I lazily hardcoded it:
> Thank you for both of your patches. Fixes build on ARM here.
> Your patch got line-wrapped though. You should be able to
> notice it by e.g. by looking at the ML archive. If you cannot
> get it through unmangled, consider attaching the patch next time.
> For this time I repaired it manually myself.
Sorry about the mangling. The HTML version of the mail is correct so I
failed to see this issue initially.
Any chance to get this committed?
> As for the question for when to define HAVE_SECTION_DATA_REL_RO:
> I do not have much knowledge about the ARM platform. I only used
> it with Linux so far. As far as Linux vs Android is concerned, I
> do not think we differentiate Linux and Android in MPlayer at all.
> Maybe some other developer can comment. Reimar?
> > By the way... is there still benefits to compile MPlayer with the internal FFmpeg instead of using an external one (as the later is less subject to configure breakage)?
ping, as well.
MPlayer-dev-eng mailing list