Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH] Enable energy saving option and screensaver mode when the video is paused.

Ferenc Czumbil wrote:

On 28/01/15 00:09, Reimar Döffinger wrote:

On 25.01.2015, at 01:43, Hans-Dieter Kosch <hdkosch@xxxxxxxxxx> wrote:

Ferenc Czumbil wrote:

On 01/12/14 22:40, Reimar Döffinger wrote:
On Mon, Dec 01, 2014 at 05:57:47PM +0200, Ferenc Czumbil wrote:
On 29/11/14 23:58, Hans-Dieter Kosch wrote:
Reimar Döffinger wrote:

On Thu, Nov 27, 2014 at 07:09:26PM +0200, Ferenc Czumbil wrote:

Currently, by default, energy saving and the screensaver is disabled
when mplayer starts and is re-enabled on exit.

This re-enables them when the video is paused. Fixes bug #2112
I'm not sure everyone likes this behaviour.
It might be better to add an option to choose the behaviour.
I'd also vote for a selectable behaviour. A user may want to observe a
picture of a paused stream, and then annoyingly the screensaver

Should I add a new separate option? Or would it be better to have a single
option for selecting the desired behaviour? Something like:

-stop-xscreensaver true|false|on_playback
The idea sounds nice but I see two issues:
1) It will probably be somewhat more complex
2) It will probably break existing config files

So I'd expect a separate option to be the better solution.
Fair enough. It was a long time ago when I did some programming and I'm not familiar with the source code of mplayer, but the attached patch seams to work (at least for me). I'm open to any further suggestions.
I'd suggest consistent naming for easier readability and sanity of the code:

"xsaver-when-paused" --> "xscreensaver-when-paused"
xsaver_when_paused   --> xscreensaver_when_paused

And I think of clarification (also in the docs) about the priority: According to your code, your option is effective when the screen saver is disabled and it overrides that setting. That's of course perfectly logical but may not be obvious to the user.
Just a heads-up: patch seems good to me, and I'll apply it if/when I have time for it while doing the above suggested changes. Unless someone else finds time and sends an updated patch before.

Cool. Thank you.

I renamed the variables, but I need a little help with finding a good description for the option. I think I figured out how to edit the man page, but I'm not satisfied with any of my attempts to provide a short and clear description of the option.

Short precise descriptions are mostly not easy. Just make a proposal. I'd volunteer to review. Except, of course, if somebody of the developers prefers to do that.

My mother tongue is Hungarian, so I'd more then happy to help with the Hungarian translation.


MPlayer-dev-eng mailing list