Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH] Fix build error with -Werror=format-security in i386

Hi Miguel!

On 2014-12-06 19:08 -0500, Miguel A. Colón Vélez wrote:
> Distributions like Fedora and the Debian family enable
> Werror=format-security by default and most of these issues have
> already been fixed in previous svn revisions. The following 1 line
> patch fixes the current issue and allows compilation (tested in
> Debian/i386) with svn r37329.

  Patch committed. 

  At first it looked a bit like the function isn't used at all, but
after looking at the configure check for libvstream-client I think
it is used. Seems the lib assumes the user of the lib to link in a
function that has exactly that name and signature.

Thanks you for the patch,

> --- a/stream/stream_vstream.c
> +++ b/stream/stream_vstream.c
> @@ -57,7 +57,7 @@
>      va_start(va, format);
>      vsnprintf(buf, 1024, format, va);
>      va_end(va);
> -    mp_msg(MSGT_STREAM, MSGL_ERR, buf);
> +    mp_msg(MSGT_STREAM, MSGL_ERR, "%s", buf);
>  }
>  static struct stream_priv_s {

Attachment: pgpnRgUYBYTN0.pgp
Description: PGP signature

MPlayer-dev-eng mailing list