Re: [MPlayer-dev-eng] [PATCH] Fix hrtf for stereo source
- Date: Sat, 6 Dec 2014 12:17:05 +0100
- From: Reimar Döffinger <Reimar.Doeffinger@xxxxxx>
- Subject: Re: [MPlayer-dev-eng] [PATCH] Fix hrtf for stereo source
On Fri, Dec 05, 2014 at 12:49:23AM +0300, Yuriy Kaminskiy wrote:
> Reimar Döffinger wrote:
> > On Tue, Dec 02, 2014 at 09:47:20PM +0300, Yuriy Kaminskiy wrote:
> >> In stereo mode (nch = 2) hrtf filter feeds junk (in..in) into "bass
> >> compensation delay line" (and access past end of buffer while reading last
> >> sample(s), resulting in periodic clicks in some cases).
> >> This looks like regression from svn r15385 ("actually output 2 channel audio
> >> (instead of 6 channel with 4 empty channels)"), before that (dummy) 5-channel
> >> input was forced (or so it looks).
> >> Attached patch should fix this.
> > Sure that is the right way?
> > Should that statement sum up the matrix-decoded values or should it
> > only sum the raw input values?
> > Or to put it differently: is your version more correct or something like
> > this:
> Your variant certainly better matches pre-r15385, so maybe it should be
> preferred (as in "don't mingle bugfixes with semantic changes").
> Which is "more correct", no idea.
I committed mine (fixed), with a TODO in case someone has a strong
opinion on which is correct.
MPlayer-dev-eng mailing list