Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH] Fix MicroDVD color tag




Hello,
Patch committed.

On Wed, Nov 26, 2014 at 07:51:42PM +0100, Michal Wazgird wrote:
> On Tue, Nov 25, 2014 at 9:48 PM, Reimar Döffinger
> <Reimar.Doeffinger@xxxxxx> wrote:
> > If you want, I don't particularly want it and am fine with your patch as-is.
> > Printing it only once and instead at WARN level might be more useful (as the purpose would be to be annoying enough so that people at least stop creating invalid files).
> > But as said, it's just an option in case you don't like silently ignoring missing/extra $# etc.
> 
> 
> I like the idea of WARN message, but I don't know how to do it. Some
> ugly global variable to store the state, that message was printed
> already?

A simple but ugly way is to just have a "static int message_printed;"
that you set to 1 after printing.

> My C knowledge is old and rather limited, so maybe let's finish here.
> I don't want to make any trouble :)

You're not (even if it takes me some time to respond).
You're welcome to try implementing that, but it's totally up to you.
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng