Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH] Fix MicroDVD color tag




On 25.11.2014, at 18:55, Michal Wazgird <mplayer@xxxxxxxxx> wrote:
> On Mon, Nov 24, 2014 at 4:21 PM, Reimar Döffinger <Reimar.Doeffinger@xxxxxx>
> wrote:
> 
>> On 23.11.2014, at 11:51, Michal Wazgird <mplayer@xxxxxxxxx> wrote:
>>> On Sat, Nov 22, 2014 at 6:04 PM, compn <tempn@xxxxxxxxx> wrote:
>>> 
>>>> On Sat, 22 Nov 2014 15:53:14 +0100
>>>> Michal Wazgird <mplayer@xxxxxxxxx> wrote:
>>>> 
>>>>> This is my first patch submission, so sorry for any misbehaviour :)
>>>> 
>>>> you forgot to attach it! :)
>>>> 
>>> 
>>> Sorry :)
>>> This time with attachment. And to proper mail :)
>> 
>> Thanks, but I prefer the way this was applied in FFmpeg, which just skips
>> any and all $ and # at the start.
>> You patch would break any subtitles that do not start with a $.
>> 
> 
> Fixed. Now skips all $ and #.

Thanks.

>> I don't mind if you want it to warn about subtitles that do not match the
>> specification, but I'd like us to accept them anyway.
>> 
> 
> I'm not sure what you mean here. Do you want me to display a warning
> message everytime a non-spec tag is being parsed? Something like this?:
> 
> mp_msg(MSGT_SUBREADER,MSGL_V,"SUB: Parsed non-spec MicroDVD tag: %s\n",
> tag);

If you want, I don't particularly want it and am fine with your patch as-is.
Printing it only once and instead at WARN level might be more useful (as the purpose would be to be annoying enough so that people at least stop creating invalid files).
But as said, it's just an option in case you don't like silently ignoring missing/extra $# etc.
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng