Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH] Fix MicroDVD color tag

On 23.11.2014, at 11:51, Michal Wazgird <mplayer@xxxxxxxxx> wrote:
> On Sat, Nov 22, 2014 at 6:04 PM, compn <tempn@xxxxxxxxx> wrote:
>> On Sat, 22 Nov 2014 15:53:14 +0100
>> Michal Wazgird <mplayer@xxxxxxxxx> wrote:
>>> This is my first patch submission, so sorry for any misbehaviour :)
>> you forgot to attach it! :)
> Sorry :)
> This time with attachment. And to proper mail :)

Thanks, but I prefer the way this was applied in FFmpeg, which just skips any and all $ and # at the start.
You patch would break any subtitles that do not start with a $.
I don't mind if you want it to warn about subtitles that do not match the specification, but I'd like us to accept them anyway.
MPlayer-dev-eng mailing list