Web lists-archives.com

Re: [MPlayer-dev-eng] [Patch] mpcodec: Use XXX_INLINE defines for inline asm

On Tue, Nov 11, 2014 at 08:53:38AM +0100, Reimar Döffinger wrote:
> On 07.11.2014, at 13:33, Matt Oliver <protogonoi@xxxxxxxxx> wrote:
> > This patch is based on one supplied to FFmpeg devel. Currently the mpcodec
> > code uses pre-processor defines such as HAVE_MMX for inline asm, given
> > mplayer and ffmpeg have a HAVE_MMX_INLINE define specific for inline asm
> > then the preprocessors can be changed to the _INLINE variants which were
> > made for this purpose.
> > 
> > This allows for proper compilation on architectures where things like MMX
> > are available but inline asm isnt and is required for compiling mpcodec
> > with compilers that dont support inline asm (such as msvc as used by
> > FFmpeg).
> > 
> > This patch updates all sections in mpcodecs not just those used by FFmpeg
> > in order to keep everything consistent. Let me know what you think.
> I forgot to say: looks good to me.
> I'll try to find time to commit, unless someone beats me to it.



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle

Attachment: signature.asc
Description: Digital signature

MPlayer-dev-eng mailing list