Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH 2/2] demux_lavf: Also add AV_CODEC_ID_OTF attachments




On 2014-10-25 13:43 +0200, Nicolas George wrote:
> Le quartidi 4 brumaire, an CCXXIII, Alexander Strasser a écrit :
> > Make those font attachments work with demux_lavf.
> > 
> > Fix other part of 2207
> > 
> > Signed-off-by: Alexander Strasser <eclipse7@xxxxxxx>
> > ---
> >  libmpdemux/demux_lavf.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> This looks right too, except for a small nitpick:
> 
[...]
> >                  AVDictionaryEntry *fnametag = av_dict_get(st->metadata, "filename", NULL, 0);
> > +                AVDictionaryEntry *mimetype = av_dict_get(st->metadata, "mimetype", NULL, 0);
> >                  demuxer_add_attachment(demuxer, fnametag ? fnametag->value : NULL,
> > -                                       "application/x-truetype-font",
> 
> > +                                       mimetype ? mimetype->value : "application/x-truetype-font",
> 
> application/x-font would seem like a saner fallback if it works.

  I thought about that too... I am not sure it is actually saner, but
it works for me. And it should usually not matter anyway AFAICT.

  Committed with the requested change.

Thanks,
  Alexander

Attachment: pgpuB68oq9k5Q.pgp
Description: PGP signature

_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng