Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH 1/2] Pass application/vnd.ms-opentype attachments to libass




On 2014-10-25 13:42 +0200, Nicolas George wrote:
> Le quartidi 4 brumaire, an CCXXIII, Alexander Strasser a écrit :
> > Make those font attachments work with at least demux_mkv.
> > 
> > Fix part of ticket 2207
> > Signed-off-by: Alexander Strasser <eclipse7@xxxxxxx>
> > ---
> >  mplayer.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> I think this is a good idea.

Committed as is because it should fix a reported issue
and I didn't want to delay it.

> > diff --git a/mplayer.c b/mplayer.c
> > index 6a32e88..482bf53 100644
> > --- a/mplayer.c
> > +++ b/mplayer.c
> > @@ -3436,6 +3436,7 @@ goto_enable_cache:
> >              if (extract_embedded_fonts &&
> >                  att->name && att->type && att->data && att->data_size &&
> >                  (strcmp(att->type, "application/x-truetype-font") == 0 ||
> 
> > +                 strcmp(att->type, "application/vnd.ms-opentype") == 0 ||
> 
> This one seems widely used, especially by mkvmerge, so it must be there.
> 
> But while you are at it, maybe add the official MIME type for OpenType and
> other fonts, i.e. application/font-sfnt.

  I will send a new patch for that.

> >                   strcmp(att->type, "application/x-font") == 0))
> >                  ass_add_font(ass_library, att->name, att->data, att->data_size);
> >          }
> > -- 

Thank you for reviewing,
  Alexander

Attachment: pgpoq2oF8_mcN.pgp
Description: PGP signature

_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng