Re: [MPlayer-dev-eng] [PATCH] mencoder slang vobsub fix
- Date: Tue, 9 Sep 2014 10:23:04 -0400
- From: Edward Batutis <edward@xxxxxxxxxxx>
- Subject: Re: [MPlayer-dev-eng] [PATCH] mencoder slang vobsub fix
I'm sure what you say is true.
Without this patch I believe that subtitle selection is completely broken
in mencoder - I tried a lot of things before making this patch. The patch
has functional limitations, but it gives a user at least one way to select
The coding style is not what I would personally prefer, but it matches the
style of the existing code to the best of my ability.
On Sat, Sep 6, 2014 at 4:06 PM, Reimar DÃffinger <Reimar.Doeffinger@xxxxxx>
> On Fri, Sep 05, 2014 at 06:30:26PM -0400, Edward Batutis wrote:
> > Reimar:
> > Thanks for your reply.
> > I am using mencoder as part of a mediatomb application that recodes video
> > for tablet devices, so mencoder is still a useful thing. Sorry to hear it
> > isn't being maintained, but that's the way it goes I guess.
> > I need to do the "if" and update dvdsub_id because I am following the
> > pattern used farther down in the source file. Also, the code that uses
> > value won't do the right thing unless I set it.
> > In fact, when testing the application, I noticed that if I didn't set
> it, I
> > didn't fix the bug.
> This seems to be due to the fact the mencoder misses MPlayer's
> select_subtitle function, that probably should be shared and reused
> in order to get consistent behaviour.
> In addition mencoder misses MPlayer's load_vob_subtitle and surrounding
> code, which leads to other inconsistencies like no support for only
> forced subtitles.
MPlayer-dev-eng mailing list