Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH] mencoder slang vobsub fix




On Tue, Mar 11, 2014 at 01:12:28PM -0400, Edward Batutis wrote:
> Hi,
> 
> This is my very first patch for mplayer/mencoder.

And promptly your patch fell through the cracks :(
Very sorry about that!
Note that mencoder isn't properly maintained anymore,
which should explain why things don't work in it
that work in MPlayer, but also is the reason for my main comment:

> +    if(dvdsub_lang && dvdsub_id==-1) vobsub_set_from_lang(vo_vobsub,dvdsub_lang,&dvdsub_id);
This is quite a bit different from what MPlayer does,
increasing the risk it will break in the future
(I suspect it also means they will behave different
when they are given a certain set of options).

Why can't you just do
vobsub_set_from_lang(vo_vobsub,dvdsub_lang);
here like MPlayer does (without the if and without
changing dvdsub_id)?

Thanks,
Reimar
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng