Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH] ad_spdif.c: Flush output buffer after processing frame, fixes audio stutter




On 28.06.2014, at 22:11, Jan Andres <jandres@xxxxxxx> wrote:
> On Sat, Jun 28, 2014 at 09:59:37PM +0200, Reimar DÃffinger wrote:
>> On Sat, Jun 28, 2014 at 08:08:37PM +0200, Jan Andres wrote:
>>> @@ -265,7 +265,7 @@
>>>             sh->pts       = pts;
>>>             sh->pts_bytes = 0;
>>>         }
>>> -        ret = lavf_ctx->oformat->write_packet(lavf_ctx, &pkt);
>>> +        ret = av_write_frame(lavf_ctx, &pkt);
>> 
>> This part is obviously correct regardless, so I committed it.
>> Thanks for spotting that.
>> As mentioned I wouldn't expect it to fix things on its own though?
> 
> Yes it does, maybe I wasn't clear enough about that in my last email.
> Both of the "flush_packets" flags in lavf are on by default, so the
> above change is indeed all that's needed to fix the issue for me.

Yes, I got that information now also from the FFmpeg list.
Both are supposed to be doing exactly the same thing and the differences were just bugs.
If I have time I'll still look into the partial writes thing and if/what makes sense to do about it.
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng