Re: [MPlayer-dev-eng] [PATCH] Expunge printf from vidix/
- Date: Tue, 13 May 2014 21:13:53 +0200
- From: Reimar Döffinger <Reimar.Doeffinger@xxxxxx>
- Subject: Re: [MPlayer-dev-eng] [PATCH] Expunge printf from vidix/
On Thu, May 08, 2014 at 07:01:09PM +0200, Arne Bochem wrote:
> > I am kind of undecided.
> > From my point two things speak against it (but this isn't meant
> > as an outright rejection):
> > 1) vidix is/used to be an external project, even though we admittedly
> > modified it a lot
> From how I see it, this shouldn't be much of a problem. If, for some
> reason, it is decided to try and update to the most recent vidix
> upstream version, at worst (some) of these modifications are lost. If
> upstream or anybody else wants to use mplayer's vidix outside mplayer,
> it should be easy enough to mechanically convert mp_msg back to printf.
> Is there something I am missing, where adding further modifications
> could be an issue in this regard?
> > 2) does anyone still actually care about it anyway?
> I have seen 5 or so people mention that they use vidix in #mplayer over
> the last months and one of them actually ran into the issue of
> -really-quiet not working correctly when using vidix. Of course, 5 isn't
> exactly a high number, but there seem to be at least a few people who
> still care about it.
Ok, I guess that makes for a reasonable argument.
If any other developer has time to commit, I have no objections.
Will probably take a few more days until I get around to do it myself
MPlayer-dev-eng mailing list