Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH] mencoder: Support flushing audio encoders at end of stream.




On Wed, May 7, 2014 at 4:01 AM, Reimar DÃffinger
<Reimar.Doeffinger@xxxxxx> wrote:
> +                               // try flushing encoder
> +                               if (len <= 0 && sh_audio->ds->eof)
> +                                       len = aencoder->encode(aencoder, mux_a->buffer + mux_a->buffer_len, NULL, 0, mux_a->buffer_size-mux_a->buffer_len);

Have you checked that lavc and all other codecs properly handle a NULL
src pointer?

Wouldn't it be better to add another function to the aencoder struct
so that we can do aencoder->flush(mux_a->buffer+...) rather than
overload a function with multiple meanings?

Also, I don't see anything which is going to trigger the lavc's own
frame padding here - does it do it automatically?

Kieran
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng