Web lists-archives.com

Re: [MPlayer-dev-eng] [PATCH] mencoder: detect end of audio stream while encoded data still buffered




On Sun, May 4, 2014 at 4:25 PM, Reimar DÃffinger
<Reimar.Doeffinger@xxxxxx> wrote:
> On 04.05.2014, at 13:46, Kieran Clancy <clancy.kieran+mplayer@xxxxxxxxx> wrote:
>> On Sun, May 4, 2014 at 9:14 PM, Grozdan <neutrino8@xxxxxxxxx> wrote:
>>>
>>> I see it now, but didn't Reimar say it doesn't make sense a few mails back?
>>
>> Yes, so I asked him to look more closely. I still believe the patch is correct.
>
> Yes, after you pointed out how it works I think it kind of is.
> I do think it's less obvious than it should be though, and I am not sure it doesn't have issues like flushing the encoder buffer even on decode errors instead of EOF plus I suspect the same hang bug exists in certain -oac copy cases which this patch won't fix since it only affects the encoding case.

Reimar, are you going to commit this patch or not? Should I wait until
it's committed before pulling from SVN?

> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng@xxxxxxxxxxxx
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng



-- 
Yours truly
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng