Web lists-archives.com

Re: [linux-usb-devel] [PATCH] Active Huawei E220 devs

Hello Greg,

Will you accept it?

best wishes


Huawei Technologies
Wireless Terminal R&D Dept

----- 原邮件 -----
发件人: linlei 60022748 <linlei83@xxxxxxxxxx>
日期: 星期二, 六月 26日, 2007 下午4:06
主题: Re: [linux-usb-devel][PATCH] Active Huawei E220 devs

> Phil,
> Thank you for accept the unusual_devs.h portion of the previous patch.
> Greg,
> This is the updated patch, please check it. 
> best wishes
> Linlei
> Huawei Technologies
> Wireless Terminal R&D Dept
linlei 60022748 wrote:
> Hi there,
> This patch make the HUAWEI E220 device to map out three ports instead of only one virtural cd port.
> See the patch for the full explanation, CC's, and sign-off. And please apply.

Short of Greg's point that the return status of usb_control_msg() isn't
checked, the patch looks good to me. Or, more specifically, I'm signing off
on the unusual_devs.h portion of it.

So when ya'll send an updated version, I'll add my Signed-off-by.

Phil Dibowitz                             phil@xxxxxxxx
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Never write it in C if you can do it in 'awk';
 Never do it in 'awk' if 'sed' can handle it;
 Never use 'sed' when 'tr' can do the job;
 Never invoke 'tr' when 'cat' is sufficient;
 Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming

This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
To unsubscribe, use the last form field at: