Re: [PATCH -mm] mm, swap: Fix bad swap file entry warning
- Date: Sat, 01 Jun 2019 08:14:29 +0800
- From: "Huang\, Ying" <ying.huang@xxxxxxxxx>
- Subject: Re: [PATCH -mm] mm, swap: Fix bad swap file entry warning
Michal Hocko <mhocko@xxxxxxxxxx> writes:
> On Fri 31-05-19 10:41:02, Huang, Ying wrote:
>> From: Huang Ying <ying.huang@xxxxxxxxx>
>> Mike reported the following warning messages
>> get_swap_device: Bad swap file entry 1400000000000001
>> This is produced by
>> - total_swapcache_pages()
>> - get_swap_device()
>> Where get_swap_device() is used to check whether the swap device is
>> valid and prevent it from being swapoff if so. But get_swap_device()
>> may produce warning message as above for some invalid swap devices.
>> This is fixed via calling swp_swap_info() before get_swap_device() to
>> filter out the swap devices that may cause warning messages.
>> Fixes: 6a946753dbe6 ("mm/swap_state.c: simplify total_swapcache_pages() with get_swap_device()")
> I suspect this is referring to a mmotm patch right?
> There doesn't seem
> to be any sha like this in Linus' tree AFAICS. If that is the case then
> please note that mmotm patch showing up in linux-next do not have a
> stable sha1 and therefore you shouldn't reference them in the commit
> message. Instead please refer to the specific mmotm patch file so that
> Andrew knows it should be folded in to it.
Thanks for reminding! I will be more careful in the future. It seems
that Andrew has identified the right patch to be folded into.