Re: [PATCH 3/5] asm-generic: Register fchmodat4 as syscall 428
- Date: Fri, 31 May 2019 16:57:53 -0700 (PDT)
- From: Palmer Dabbelt <palmer@xxxxxxxxxx>
- Subject: Re: [PATCH 3/5] asm-generic: Register fchmodat4 as syscall 428
On Fri, 31 May 2019 12:56:39 PDT (-0700), Arnd Bergmann wrote:
On Fri, May 31, 2019 at 9:23 PM Palmer Dabbelt <palmer@xxxxxxxxxx> wrote:
Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxx>
As usual, each patch needs a changelog text. I would prefer having a single
patch here that changes /all/ system call tables at once, rather than doing one
at a time like we used to.
Works for me. That also gives me something to write about it the text :)
In linux-next, we are at number 434 now, and there are a couple of other
new system calls being proposed right now (more than usual), so you may
have to change the number a few times.
OK, no problem. It'll be a bit easier to handle the number that way.
Note: most architectures use .tbl files now, the exceptions are
include/uapi/asm-generic/unistd.h and arch/arm64/include/asm/unistd32.h,
and the latter also requires changing __NR_compat_syscalls in asm/unistd.h.
Numbers should now be the same across architectures, except for alpha,
which has a +110 offset. We have discussed ways to have a single
file to modify for a new call on all architectures, but no patches yet.
OK, thanks. I'll wait a bit for feedback, but unless there's anything else
I'll go ahead and finish this.