Web lists-archives.com

Re: [PATCH] btrfs: Fix -Wunused-but-set-variable warnings




On Fri, 2019-05-31 at 23:31 +0300, Andrey Abramov wrote:
> 31.05.2019, 23:05, "Joe Perches" <joe@xxxxxxxxxxx>:
> > On Fri, 2019-05-31 at 22:53 +0300, Andrey Abramov wrote:
> > >  Fix -Wunused-but-set-variable warnings in raid56.c and sysfs.c files
> > These uses seem boolean, so perhaps just use bool?
> I used int because you use ints (as bools) everywhere (for example
> there is only one bool (as a function argument) in the entire raid56.c
> file with 3000 lines of code), so with int code looks more consistent.
> Are you sure that I should use bool?

That's up to you and the btrfs maintainers.