Re: [PATCH v1] s390/pkey: Use -ENODEV instead of -EOPNOTSUPP
- Date: Fri, 31 May 2019 11:50:55 +0200
- From: Cornelia Huck <cohuck@xxxxxxxxxx>
- Subject: Re: [PATCH v1] s390/pkey: Use -ENODEV instead of -EOPNOTSUPP
On Fri, 31 May 2019 11:36:28 +0200
David Hildenbrand <david@xxxxxxxxxx> wrote:
> systemd-modules-load.service automatically tries to load the pkey module
> on systems that have MSA.
> Pkey also requires the MSA3 facility and a bunch of subfunctions.
> Failing with -EOPNOTSUPP makes "systemd-modules-load.service" fail on
> any system that does not have all needed subfunctions. For example,
> when running under QEMU TCG (but also on systems where protected keys
> are disabled via the HMC).
> Let's use -ENODEV, so systemd-modules-load.service properly ignores
> failing to load the pkey module because of missing HW functionality.
> Cc: Harald Freudenberger <freude@xxxxxxxxxxxxx>
> Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> Cc: Cornelia Huck <cohuck@xxxxxxxxxx>
> Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
> drivers/s390/crypto/pkey_api.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Looking at what other modules return when needed features are missing,
this looks like the right thing to do.
Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>