Re: [PATCH] rtc: test: enable wakeup flags
Thank you for the review.
See my answers below.
On Wed, May 15, 2019 at 3:32 PM Alexandre Belloni
> (You didn't use my correct email address, please update your kernel)
> On 15/05/2019 14:14:36+0300, roman.stratiienko@xxxxxxxxxxxxxxx wrote:
> > From: Roman Stratiienko <roman.stratiienko@xxxxxxxxxxxxxxx>
> > Alarmtimer interface uses only the RTC with wekeup flags enabled.
> > Allow to use rtc-test driver with alarmtimer interface.
> > Signed-off-by: Roman Stratiienko <roman.stratiienko@xxxxxxxxxxxxxxx>
> > ---
> > drivers/rtc/rtc-test.c | 2 ++
> > 1 file changed, 2 insertions(+)
> > diff --git a/drivers/rtc/rtc-test.c b/drivers/rtc/rtc-test.c
> > index 6c5f09c815e8..c839ae575c77 100644
> > --- a/drivers/rtc/rtc-test.c
> > +++ b/drivers/rtc/rtc-test.c
> > @@ -123,6 +123,8 @@ static int test_probe(struct platform_device *plat_dev)
> > platform_set_drvdata(plat_dev, rtd);
> > + device_init_wakeup(&plat_dev->dev, 1);
> > +
> The first created RTC doesn't have any alarm, so this must not be done
> for all the devices.
Thanks. I will fix this in v2.
> Also, this driver will never wake up the platform so I'm not sure it is
> relevant to test alarmtimers.
Alarmtimer interface relies only on RTC with alarm support,
but it also checks wake flags for some reason.
As far as rtc-test driver do have alarm support, I expect
that related drivers should use it.
Let me share some information about my use-case:
Alarmtimer support is required for generic AOSP bluedroid library.
To enable Bluetooth in Android on the devices that does not
have hardware RTC, enabling rtc-test driver is a good option.
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
Global Logic Inc.