Web lists-archives.com

Re: [PATCH] bsr: do not use assignment in if condition




On Wed, May 15, 2019 at 06:45:24PM +0530, parna.naveenkumar@xxxxxxxxx wrote:
> From: Naveen Kumar Parna <parna.naveenkumar@xxxxxxxxx>
> 
> checkpatch.pl does not like assignment in if condition
> 
> Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@xxxxxxxxx>
> ---
>  drivers/char/bsr.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
> index a6cef548e01e..2b00748b83d2 100644
> --- a/drivers/char/bsr.c
> +++ b/drivers/char/bsr.c
> @@ -322,7 +322,8 @@ static int __init bsr_init(void)
>  		goto out_err_2;
>  	}
>  
> -	if ((ret = bsr_create_devs(np)) < 0) {
> +	ret = bsr_create_devs(np);
> +	if (ret  < 0) {

Checkpatch also probably does not like that if statement :(