Re: [PATCH] ipmi: avoid atomic_inc in exit function
- Date: Mon, 15 Apr 2019 09:40:22 -0700
- From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
- Subject: Re: [PATCH] ipmi: avoid atomic_inc in exit function
On Mon, Apr 15, 2019 at 05:55:00PM +0200, Arnd Bergmann wrote:
> This causes a link failure on ARM in certain configurations,
> when we reference each atomic operation from .alt.smp.init in
> order to patch out atomics on non-SMP systems:
> `.exit.text' referenced in section `.alt.smp.init' of drivers/char/ipmi/ipmi_msghandler.o: defined in discarded section `.exit.text' of drivers/char/ipmi/ipmi_msghandler.o
> In this case, we can trivially replace the atomic_inc() with
> an atomic_set() that has the same effect and does not require
> a fixup.
I'd rather fіx the arm section management. Using atomic in exit
routines is perfectly valid, and it would seem odd to forbid it.