[PATCH v2 23/36] coresight: Cleanup coresight_remove_conns
- Date: Mon, 15 Apr 2019 17:04:06 +0100
- From: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
- Subject: [PATCH v2 23/36] coresight: Cleanup coresight_remove_conns
When a device is unregistered, we remove all connection
references to it, by searching the connection records of
all devices in the coresight bus, via coresight_remove_conns.
We could avoid searching if this device doesn't have an input
port (e.g, a source). Also document the purpose of the function.
Cc: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
drivers/hwtracing/coresight/coresight.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
index 91c63cd..530ad69 100644
@@ -1094,10 +1094,21 @@ static int coresight_remove_match(struct device *dev, void *data)
+ * coresight_remove_conns - Remove references to this given devices
+ * from the connections of other devices.
static void coresight_remove_conns(struct coresight_device *csdev)
- bus_for_each_dev(&coresight_bustype, NULL,
- csdev, coresight_remove_match);
+ * Another device will point to this device only if there is
+ * an output port connected to this one. i.e, if the device
+ * doesn't have at least one input port, there is no point
+ * in searching all the devices.
+ if (csdev->nr_inport)
+ bus_for_each_dev(&coresight_bustype, NULL,
+ csdev, coresight_remove_match);