Web lists-archives.com

Re: [PATCH] drm/v3d: Use the new shmem helpers to reduce driver boilerplate.




Rob Herring <robh@xxxxxxxxxx> writes:

> On Thu, Mar 14, 2019 at 11:34 AM Eric Anholt <eric@xxxxxxxxxx> wrote:
>>
>> The new shmem helpers from Noralf and Rob abstract out a bunch of our
>> BO creation and mapping code.
>>
>> v2: Use the new sgt getter, and flag pages as dirty before freeing.
>>
>> Signed-off-by: Eric Anholt <eric@xxxxxxxxxx>
>> ---
>>  drivers/gpu/drm/v3d/Kconfig   |   1 +
>>  drivers/gpu/drm/v3d/v3d_bo.c  | 317 ++++++++++------------------------
>>  drivers/gpu/drm/v3d/v3d_drv.c |  27 +--
>>  drivers/gpu/drm/v3d/v3d_drv.h |  14 +-
>>  drivers/gpu/drm/v3d/v3d_gem.c |  12 +-
>>  drivers/gpu/drm/v3d/v3d_irq.c |   8 +-
>>  drivers/gpu/drm/v3d/v3d_mmu.c |  11 +-
>>  7 files changed, 120 insertions(+), 270 deletions(-)
>
>> diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
>> index 945eaaaad016..b84d89c7b3fb 100644
>> --- a/drivers/gpu/drm/v3d/v3d_gem.c
>> +++ b/drivers/gpu/drm/v3d/v3d_gem.c
>> @@ -201,7 +201,8 @@ v3d_attach_object_fences(struct v3d_bo **bos, int bo_count,
>>
>>         for (i = 0; i < bo_count; i++) {
>>                 /* XXX: Use shared fences for read-only objects. */
>> -               reservation_object_add_excl_fence(bos[i]->base.resv, fence);
>> +               reservation_object_add_excl_fence(bos[i]->base.base.resv,
>> +                                                 fence);
>
> All these 'bos[i]->base.base' occurrences are not the prettiest.
> Changing your bos array to a struct drm_gem_object ** instead would
> help. That's what I did for panfrost. Though I've not looked at were
> you actually need the v3d_bo.

Agreed that would probably be a goodcleanup, but I'm hoping I can land
the compute shaders first.  I've been doing a lot of rebasing of that
series and I want to just get it done.

Attachment: signature.asc
Description: PGP signature