Web lists-archives.com

RE: [PATCH] scsi: ufs: fix a missing check of devm_reset_control_get




Hi,
> 
> Signed-off-by: Kangjie Lu <kjlu@xxxxxxx>
Acked-by: Avri Altman <avri.altman@xxxxxxx>

> ---
>  drivers/scsi/ufs/ufs-hisi.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c
> index 452e19f8fb47..ce9d7c40909f 100644
> --- a/drivers/scsi/ufs/ufs-hisi.c
> +++ b/drivers/scsi/ufs/ufs-hisi.c
> @@ -544,6 +544,11 @@ static int ufs_hisi_init_common(struct ufs_hba *hba)
>  	ufshcd_set_variant(hba, host);
> 
>  	host->rst  = devm_reset_control_get(dev, "rst");
> +	if (IS_ERR(host->rst)) {
> +		dev_err(dev, "%s: failed to get reset control\n",
> +			__func__);
Use full line please

> +		return PTR_ERR(host->rst);
> +	}
> 
>  	ufs_hisi_set_pm_lvl(hba);
> 
> --
> 2.17.1