Web lists-archives.com

Re: [PATCH 1/2] cifs: remove unused status severity defines




Since this file (smb2status.h) is intended to track the official
protocol documentation (albeit smb2status.h probably needs to be
updated), in this case the protocol document MS-ERREF.  I would prefer
to keep it closer to MS-ERREF and leave definitions in even if unused
(if nothing else it helps some of us when debugging to recognize what
these errors on the wire mean).  There is a real danger that we have
run into in the past that in removing some protocol definitions
(flags, etc.) from the code or forgetting to update our headers to
match newer versions of the protocol specifications, that  with future
code changes we can forget to handle flags (for example) or misparse
responses due to not realizing that there are additional flags that
need to be parsed.

On Thu, Mar 14, 2019 at 1:17 AM Sergey Senozhatsky
<sergey.senozhatsky.work@xxxxxxxxx> wrote:
>
> STATUS_SEVERITY_* do not appear to be used by anyone, so
> drop them. Besides, the name of __constant_cpu_to_le32()
> is misspelled there: __constanst_cpu_to_le32().
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
> ---
>  fs/cifs/smb2status.h | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/fs/cifs/smb2status.h b/fs/cifs/smb2status.h
> index 3d5f62150de4..e9da9c6da277 100644
> --- a/fs/cifs/smb2status.h
> +++ b/fs/cifs/smb2status.h
> @@ -29,11 +29,6 @@
>   *  C is set if "customer defined" error, N bit is reserved and MBZ
>   */
>
> -#define STATUS_SEVERITY_SUCCESS __constant_cpu_to_le32(0x0000)
> -#define STATUS_SEVERITY_INFORMATIONAL __constanst_cpu_to_le32(0x0001)
> -#define STATUS_SEVERITY_WARNING __constanst_cpu_to_le32(0x0002)
> -#define STATUS_SEVERITY_ERROR __constanst_cpu_to_le32(0x0003)
> -
>  struct ntstatus {
>         /* Facility is the high 12 bits of the following field */
>         __le32 Facility; /* low 2 bits Severity, next is Customer, then rsrvd */
> --
> 2.21.0
>


-- 
Thanks,

Steve