Web lists-archives.com

Re: [PATCH] mtd: physmap_of_gemini: remove extranous __xipram annotation




On Wed, Mar 13, 2019 at 10:19 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:

> Marking a local variable as __xipram causes a warning because of the
> noinline attribute:
>
> drivers/mtd/maps/physmap-gemini.c:89:11: error: '__noinline__' attribute only applies to functions [-Werror,-Wignored-attributes]
>         map_word __xipram ret;
>                  ^
> include/linux/mtd/xip.h:34:18: note: expanded from macro '__xipram'
>  #define __xipram noinline __attribute__ ((__section__ (".xiptext")))
>
> I can't see any reason for the anotation anyway, so just remove it here.
>
> Fixes: 9d3b5086f6d4 ("mtd: physmap_of_gemini: Handle pin control")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij