Web lists-archives.com

Re: [PATCH] mm/gup.c: Remove unused write variable




On Sun, Feb 10, 2019 at 08:39:44PM +0100, Thomas Gleixner wrote:
> Ira,
> 
> On Sat, 9 Feb 2019, ira.weiny@xxxxxxxxx wrote:
> 
> nice patch. Just a few nitpicks vs. the subject and the change log.
> 
> > Subject: [PATCH] mm/gup.c: Remove unused write variable
> 
> We usually avoid filenames in the subsystem prefix. mm/gup: is sufficient.

Thanks.

> 
> But what's a bit more confusing is 'write variable'. You are not removing a
> variable, you are removing a unused function argument. That's two different
> things.

Indeed my mistake.

> 
> > write is unused in gup_fast_permitted so remove it.
> 
> When referencing functions please use brackets so it's clear that you talk
> about a function, i.e. gup_fast_permitted().
> 
> So the correct subject line would be:
> 
>   Subject: [PATCH] mm/gup: Remove write argument from gup_fast_permitted()

NP, V2 on its way,
Ira

> 
> Thanks,
> 
> 	tglx