Web lists-archives.com

[tip:x86/urgent] x86/mm: Make set_pmd_at() paravirt aware

Commit-ID:  20e55bc17dd01f13cec0eb17e76e9511b23963ef
Gitweb:     https://git.kernel.org/tip/20e55bc17dd01f13cec0eb17e76e9511b23963ef
Author:     Juergen Gross <jgross@xxxxxxxx>
AuthorDate: Sun, 10 Feb 2019 08:40:56 +0100
Committer:  Thomas Gleixner <tglx@xxxxxxxxxxxxx>
CommitDate: Sun, 10 Feb 2019 08:47:12 +0100

x86/mm: Make set_pmd_at() paravirt aware

set_pmd_at() calls native_set_pmd() unconditionally on x86. This was
fine as long as only huge page entries were written via set_pmd_at(),
as Xen pv guests don't support those.

Commit 2c91bd4a4e2e53 ("mm: speed up mremap by 20x on large regions")
introduced a usage of set_pmd_at() possible on pv guests, leading to
failures like:

BUG: unable to handle kernel paging request at ffff888023e26778
#PF error: [PROT] [WRITE]
RIP: e030:move_page_tables+0x7c1/0xae0

Make set_pmd_at() paravirt aware by just letting it use set_pmd().

Fixes: 2c91bd4a4e2e53 ("mm: speed up mremap by 20x on large regions")
Reported-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
Cc: boris.ostrovsky@xxxxxxxxxx
Cc: sstabellini@xxxxxxxxxx
Cc: hpa@xxxxxxxxx
Cc: bp@xxxxxxxxx
Cc: torvalds@xxxxxxxxxxxxxxxxxxxx
Link: https://lkml.kernel.org/r/20190210074056.11842-1-jgross@xxxxxxxx

 arch/x86/include/asm/pgtable.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h
index 40616e805292..2779ace16d23 100644
--- a/arch/x86/include/asm/pgtable.h
+++ b/arch/x86/include/asm/pgtable.h
@@ -1065,7 +1065,7 @@ static inline void native_set_pte_at(struct mm_struct *mm, unsigned long addr,
 static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr,
 			      pmd_t *pmdp, pmd_t pmd)
-	native_set_pmd(pmdp, pmd);
+	set_pmd(pmdp, pmd);
 static inline void set_pud_at(struct mm_struct *mm, unsigned long addr,