Re: [PATCH 2/2] Drivers: hv: vmbus: Display nothing in sysfs if monitor_allocated not set
- Date: Fri, 8 Feb 2019 14:32:09 -0800
- From: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH 2/2] Drivers: hv: vmbus: Display nothing in sysfs if monitor_allocated not set
On Fri, 8 Feb 2019 05:01:12 -0500
Kimberly Brown <kimbrownkd@xxxxxxxxx> wrote:
You are right, the current behavior is broken.
It would be good to add a description of under what conditions
monitor is not used. Is this some part of a project emulating
> + if (!hv_dev->channel->offermsg.monitor_allocated)
> + return sprintf(buf, "\n");
If monitor is not used, why not return an error instead of empty
data. Any program (or user) would have to handle that already.