Web lists-archives.com

RE: [PATCH V17 3/6] i2c: tegra: fix maximum transfer size




> >  static const struct i2c_adapter_quirks tegra194_i2c_quirks = {
> >  	.flags = I2C_AQ_NO_ZERO_LEN,
> > +	.max_write_len = 65535 - I2C_PACKET_HEADER_SIZE,
>
> Ideally it should be SZ_64K - I2C_PACKET_HEADER_SIZE to not miss the one byte, otherwise good to me:
>
> Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>

With SZ_64K - I2C_PACKET_HEADR_Size, When we compute dma_buf_size = max_write_len + I2C_PACKET_HEADER_SIZE, dma_buf_size will be SZ_64K which is 0x10000 apbdma dma count limit should be < 64K meaning 65535 max is allowed